fix(hypatia): triage all 15 findings — 8 at source, 7 baselined (closes the red gate) - #146
Merged
Merged
Conversation
Source fixes:
- .hypatia-ignore: reword the API-key comment so the secret matcher's
assignment-shape no longer fires on its own exemption text (the critical)
- my-hir: replace guarded unwrap with a match on into_iter().next()
- my-lint: is_some_and guards kill 2 genuine empty-name panics
- my-llvm: SAFETY marker directly adjacent to the unsafe block (the
16-line invariant argument sat too far above for the adjacency check)
- ENSAID_CONFIG.a2ml: abi-verify workflow now targets the real Idris tree
via ipkg --build (per-file --check is a fake gate, exit 0 on missing module)
- docs/wiki/roadmap/compiler.md: 'Planned: src/{hir,mir,runtime}' paths
now point at the shipped crates
Baseline (.hypatia-baseline.json, 7 entries, expires 2026-10-27, #145):
parser.rs self.expect() name-collision FP; my-fmt infallible Write-to-String
unwraps; my-llvm internal-invariant unwraps; my-mir/string.rs deliberate
invariant expects; measure_depth example; modules.md illustrative paths.
Validated against apply-baseline.sh locally: 7 suppressed, 0 kept, exit 0.
Hygiene (owner-approved salvage from the 07-26 sweep stash):
- .gitignore: secrets/env entries only (.env, *.pem, *.key, .venv/)
- mise.toml: replace 30-tool all-'latest' boilerplate with pinned rust 1.97.0
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
hyperpolymath
added a commit
that referenced
this pull request
Jul 27, 2026
#147) Follow-up to #146 — the one finding that survived. hypatia's `unsafe_block` rule is a bare `unsafe\s*\{` regex (`lib/rules/code_safety.ex`): it flags every unsafe block regardless of documentation, so no SAFETY comment can ever satisfy it (the adjacency fix in #146 was a no-op against a rule that never looks). The single unsafe block in my-llvm is mandatory (inkwell declares `build_gep` unsafe) and fully documented, so this uses the same scoped `.hypatia-ignore` mechanism as the existing `coq_axiom`/`transmute` keyword-match exemptions — a permanent fact should not be expiring baseline debt. Upstream rule fix is a candidate for hypatia itself. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last red gate on main (governance / Validate Hypatia Baseline, failing since ≥07-22 when the scanner started actually working).
Fixed at source (8):
.hypatia-ignore:86"Generic API key": self-referential FP; the comment explaining the API-key exemption itself contained theKEY=\"...\"assignment shape. Reworded.match; my-lint 2× genuine empty-name panics →is_some_and; my-llvm SAFETY-comment adjacency.src/abi/*.idr(nonexistent) → real Idris tree via ipkg build (per-file--checkis a known fake gate).Planned: src/{hir,mir,runtime}→ the shipped crates.Baselined (7 entries, expire 2026-10-27, tracked in #145): parser
self.expect()name-collision FP (157×), my-fmt infallible Write-to-String unwraps (26×), my-llvm internal-invariant unwraps (3×), my-mir/string.rs deliberate invariant expects, measure_depth example, modules.md illustrative user-project paths.Verified: ran the reusable's own
apply-baseline.shlocally against the post-fix finding set → 7 suppressed, 0 kept, exit 0.cargo test -p my-hir -p my-lintgreen.Hygiene (owner-approved):
.gitignoresecrets entries salvaged from the 07-26 sweep stash;mise.tomlboilerplate → pinned rust 1.97.0.🤖 Generated with Claude Code